[libcxx-commits] [PATCH] D127226: [libc++] Simplify type_traits and use more builtins

Mon Jun 27 08:43:47 PDT 2022

philnik added a comment.

In D127226#3612405 <https://reviews.llvm.org/D127226#3612405>, @cjdb wrote:

> In D127226#3611394 <https://reviews.llvm.org/D127226#3611394>, @philnik wrote:
>
>> In D127226#3611365 <https://reviews.llvm.org/D127226#3611365>, @hans wrote:
>>
>>> Did the reland in https://reviews.llvm.org/rG31ae52859f7a2339f31bb78c5163c23cb872f179 address the issue raised by Alan and Manoj? The commit message only says "Stuff" :-)
>>
>> Yes I removed these parts for now. The "Stuff" in there wasn't planned, sorry.
>
> In future, would you mind adding something to describe that the problematic parts have been removed please? It'll make it easier to vet the changes because we'll know what to look for.

Yes I'll do that. I thought I had a better commit message than "Stuff".

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127226/new/

https://reviews.llvm.org/D127226