[libcxx-commits] [PATCH] D128655: [libc++] Add a few missing min/max macro push/pop

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 27 08:42:24 PDT 2022


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

Nice catch! LGTM when the CI is happy.



================
Comment at: libcxx/test/libcxx/nasty_macros.compile.pass.cpp:141
+#define min NASTY_MACRO
+#define max NASTY_MACRO
+
----------------
Interesting they weren't in the list yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128655/new/

https://reviews.llvm.org/D128655



More information about the libcxx-commits mailing list