[libcxx-commits] [PATCH] D128400: [libc++][NFC] Replace enable_if with __enable_if_t in a few places

Mon Jun 27 06:47:47 PDT 2022

philnik marked an inline comment as done.
philnik added a comment.

In D128400#3609039 <https://reviews.llvm.org/D128400#3609039>, @jloser wrote:

> This isn't quite an NFC I think. Specifically, `__enable_if_t` is marked with `_LIBCPP_NODEBUG` whereas `enable_if` is not.  The new behavior proposed in this patch results in suppressing debugging information for these functions. Does anyone rely on this behavior/care?

IIUC this only suppresses debug information of the `__enable_if_t` itself. It doesn't suppress any other debug information. So Instead of the function debug info being `enable_if<some stuff>::type` you get just `void`. So yes, it technically changes something, but I don't think anybody really cares for this part of the debug info.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128400/new/

https://reviews.llvm.org/D128400