[libcxx-commits] [libcxx] 92df8c2 - [libc++] Improve Lit's buildhost=XXXX feature on a few platforms

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2022-06-27T08:33:44-04:00
New Revision: 92df8c273669590db7cf480a89f9a0181a8c1c47

URL: https://github.com/llvm/llvm-project/commit/92df8c273669590db7cf480a89f9a0181a8c1c47
DIFF: https://github.com/llvm/llvm-project/commit/92df8c273669590db7cf480a89f9a0181a8c1c47.diff

LOG: [libc++] Improve Lit's buildhost=XXXX feature on a few platforms

Differential Revision: https://reviews.llvm.org/D128455

Added: 
    

Modified: 
    libcxx/test/libcxx/transitive_includes.sh.cpp
    libcxx/utils/libcxx/test/features.py

Removed: 
    


################################################################################
diff  --git a/libcxx/test/libcxx/transitive_includes.sh.cpp b/libcxx/test/libcxx/transitive_includes.sh.cpp
index 7c4ff67d62e42..19d6ab036f68f 100644
--- a/libcxx/test/libcxx/transitive_includes.sh.cpp
+++ b/libcxx/test/libcxx/transitive_includes.sh.cpp
@@ -32,7 +32,7 @@
 // UNSUPPORTED: gcc
 
 // This test doesn't work on AIX or Windows, but it should. Needs investigation.
-// XFAIL: buildhost=aix6, buildhost=windows
+// XFAIL: buildhost=aix, buildhost=windows
 
 // Prevent <ext/hash_map> from generating deprecated warnings for this test.
 #if defined(__DEPRECATED)

diff  --git a/libcxx/utils/libcxx/test/features.py b/libcxx/utils/libcxx/test/features.py
index d805ae6e7ac38..93842f2ea99f4 100644
--- a/libcxx/utils/libcxx/test/features.py
+++ b/libcxx/utils/libcxx/test/features.py
@@ -260,9 +260,11 @@ def _hasSuitableClangTidy(cfg):
 # The build host could 
diff er from the target platform for cross-compilation.
 DEFAULT_FEATURES += [
   Feature(name='buildhost={}'.format(sys.platform.lower().strip())),
-  # sys.platform can be represented by "sub-system" on Windows host, such as 'win32', 'cygwin', 'mingw' & etc.
-  # Here is a consolidated feature for the build host plaform name on Windows.
-  Feature(name='buildhost=windows', when=lambda cfg: platform.system().lower().startswith('windows'))
+  # sys.platform can often be represented by a "sub-system", such as 'win32', 'cygwin', 'mingw', freebsd13 & etc.
+  # We define a consolidated feature on a few platforms.
+  Feature(name='buildhost=windows', when=lambda cfg: platform.system().lower().startswith('windows')),
+  Feature(name='buildhost=freebsd', when=lambda cfg: platform.system().lower().startswith('freebsd')),
+  Feature(name='buildhost=aix', when=lambda cfg: platform.system().lower().startswith('aix'))
 ]
 
 # Detect whether GDB is on the system, has Python scripting and supports