[libcxx-commits] [PATCH] D68365: [libc++] Implement P1004R2 (constexpr std::vector)

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/__bit_reference:503
             __m = (~__storage_type(0) << __result.__ctz_) & (~__storage_type(0) >> (__clz_r - __ddn));
-            *__result.__seg_ &= ~__m;
+            *__result.__seg_ = *__result.__seg_ & ~__m;
             if (__result.__ctz_ > __first.__ctz_)
----------------
ldionne wrote:
> Why is this required?
It's not. I probably changed that during some debugging.


================
Comment at: libcxx/include/memory:923-928
+    if (__libcpp_is_constant_evaluated()) {
+        while (__begin1 != __end1)
+            std::__construct_at(__begin2++, *__begin1++);
+    } else {
+        __begin2 = std::__copy(__begin1, __end1, const_cast<_RawDest*>(__begin2)).second;
     }
----------------
ldionne wrote:
> I think this should all just be `uninitialized_copy` (or a `__` version of it).
Just for reference, this is D128146 now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68365/new/

https://reviews.llvm.org/D68365