[libcxx-commits] [PATCH] D128600: [libc++][mingw] Remove setlocale from snprintf_l

[Alvin Wong via Phabricator via libcxx-commits]

alvinhochun added a comment.

In D128600#3611043 <https://reviews.llvm.org/D128600#3611043>, @mstorsjo wrote:

> I guess the more complete/proper way forward would make a mingw-w64 specific implementation of these (or some similar) functions too, if `__USE_MINGW_ANSI_STDIO` is set to 1. (No idea offhand how hard that would be though...)

Hypothetically, if this means implementing custom formatting routines, wouldn't it be better to just use the same implementation for both msvc and mingw-w64?

(I may experiment with this for a bit, perhaps it can reuse some parts of the `std::to_chars` implementation...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128600/new/

https://reviews.llvm.org/D128600