[libcxx-commits] [PATCH] D128146: [libc++] Use uninitialized algorithms for vector

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/__memory/uninitialized_algorithms.h:506
+#ifndef _LIBCPP_NO_EXCEPTIONS
+  try {
+#endif
----------------
ldionne wrote:
> Should we have a `static_assert(__is_cpp17_copy_insertable<...>)` here?
I'm not sure. I'll investigate it later, since it breaks a lot of tests. I think it's either not applicable or the trait is currently broken. It's not used anywhere right now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128146/new/

https://reviews.llvm.org/D128146