[libcxx-commits] [PATCH] D127226: [libc++] Simplify type_traits and use more builtins

Manoj Gupta via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jun 25 12:41:39 PDT 2022


manojgupta added a comment.

> If you can't wait until Wednesday or Thursday you can always revert the diff downstream.



In D127226#3610114 <https://reviews.llvm.org/D127226#3610114>, @Mordante wrote:

> @ayzhao, @cjdb Thanks for the additional information.
>
> @philnik Is there a conflict in reverting this commit? The general LLVM policy is to keep HEAD in working order. I assume the breakage blocks people from testing HEAD so other patches after this commit are might not tested downstream until HEAD works again.
>
> I'm in favor for a quick (partial) revert, fix it, and re-land the fixed version.

I do not think delaying by a week  is a good timeline. I have reverted it for now since this is known to break multiple CIs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127226/new/

https://reviews.llvm.org/D127226



More information about the libcxx-commits mailing list