[libcxx-commits] [PATCH] D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined

[Paul Kirth via Phabricator via libcxx-commits]

paulkirth updated this revision to Diff 439889.
paulkirth marked an inline comment as done.
paulkirth added a comment.

Address outstanding review comments.

- Remove `lit` feature for making _HAS_EXCEPTIONS = 0 match no-exceptions. I was under the impression that this feature was required so that we would avoid testing unsupported configurations. I think this may no longer be necessary, and have removed it in light of @ldionne's question. In my testing this configuration seesm to work fine.

- Fix buildbot command
- Add documentation to test config file regarding _HAS_EXCEPTIONS = 0 useage
- Fix typos & whitespace


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103947/new/

https://reviews.llvm.org/D103947

Files:
  libcxx/include/exception
  libcxx/include/new
  libcxx/include/typeinfo
  libcxx/test/configs/llvm-libc++-shared-no-vcruntime-clangcl.cfg.in
  libcxx/utils/ci/buildkite-pipeline.yml
  libcxx/utils/ci/run-buildbot

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103947.439889.patch
Type: text/x-patch
Size: 8329 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220624/3fe2d3b4/attachment-0001.bin>