[libcxx-commits] [PATCH] D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined
Paul Kirth via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Jun 24 14:18:09 PDT 2022
paulkirth updated this revision to Diff 439889.
paulkirth marked an inline comment as done.
paulkirth added a comment.
Address outstanding review comments.
- Remove `lit` feature for making _HAS_EXCEPTIONS = 0 match no-exceptions. I was under the impression that this feature was required so that we would avoid testing unsupported configurations. I think this may no longer be necessary, and have removed it in light of @ldionne's question. In my testing this configuration seesm to work fine.
- Fix buildbot command
- Add documentation to test config file regarding _HAS_EXCEPTIONS = 0 useage
- Fix typos & whitespace
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 8329 bytes
Desc: not available
More information about the libcxx-commits