[libcxx-commits] [PATCH] D128285: [libc++][AIX] Make basic_string layout compatible with earlier version

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM with my comment addressed.



================
Comment at: libcxx/include/string:726-730
+        // Attribute 'packed' is used to keep the layout compatible with the
+        // previous definition that did not use bit fields. This is because
+        // on some platforms bit fields have a default size rather than
+        // the actual size used, e.g., it is 4 bytes on AIX. See D128285
+        // for details.
----------------
Could you have this comment just once above the `__long` and `__short` structs? Having it cloned makes it a lot easier for them to get out of sync.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128285/new/

https://reviews.llvm.org/D128285