[libcxx-commits] [PATCH] D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined

Paul Kirth via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 23 16:06:49 PDT 2022


paulkirth updated this revision to Diff 439562.
paulkirth added a comment.

Address comments

- Remove usage of _LIBCPP_HIDE_FROM_ABI, I don't see any remaining functions that need them after moving away from strict layout conformance w/ vcruntime.
- Remove unused fuction.
- Make the `_HAS_EXCEPTIONS == 0' definitions for bad_alloc mutually exclusive with the existing preprocessor directives.
- Rename test configurations and files for CI

I still need to figure out if the `lit` feature can be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103947/new/

https://reviews.llvm.org/D103947

Files:
  libcxx/include/exception
  libcxx/include/new
  libcxx/include/typeinfo
  libcxx/src/support/runtime/exception_msvc.ipp
  libcxx/test/configs/llvm-libc++-shared-no-vcruntime-clangcl.cfg.in
  libcxx/test/support/test.support/test_macros_header.no_exceptions.verify.cpp
  libcxx/test/support/test_macros.h
  libcxx/utils/ci/buildkite-pipeline.yml
  libcxx/utils/ci/run-buildbot
  libcxx/utils/libcxx/test/features.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103947.439562.patch
Type: text/x-patch
Size: 11886 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220623/55050370/attachment.bin>


More information about the libcxx-commits mailing list