[libcxx-commits] [PATCH] D127226: [libc++] Simplify type_traits and use more builtins

Thu Jun 23 13:36:57 PDT 2022

ayzhao added a comment.

In D127226#3603886 <https://reviews.llvm.org/D127226#3603886>, @Mordante wrote:

> In D127226#3602787 <https://reviews.llvm.org/D127226#3602787>, @manojgupta wrote:
>
>> This seems like same as the problem that was fixed by https://reviews.llvm.org/rGe6a39f00e8d0cd3684df54fb03d288efe2969202 and re-introduced by this patch.
>
> Unfortunately it seems this revert wasn't followed up by a regression test.
>
> I agree we should fix this **and** add tests for `__float128` and for other non-standard types broken by this commit.
> That way we can avoid future regressions.
>
> I think we should also have a look at the gcc/clang manuals for additional non-standard types and evaluate their status.
>
> @ayzhao, @manojgupta, @cjdb are you aware of other types that are broken by this commit?

I don't know of any others off of the top of my head, but based on the definition of __is_arithmetic(...) <https://github.com/llvm/llvm-project/blob/d5475af2f7616a66d3c79218c72b6336b7e1f483/clang/lib/AST/Type.cpp#L2153-L2156>, all of the following types are now suspect: https://github.com/llvm/llvm-project/blob/1b24fe34b06cd9f2337313f513a8b19f9a37c5de/clang/include/clang/AST/BuiltinTypes.def#L62-L222

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127226/new/

https://reviews.llvm.org/D127226