[libcxx-commits] [PATCH] D128139: [libc++][format] Improve integral formatters.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D128139#3597167 <https://reviews.llvm.org/D128139#3597167>, @ldionne wrote:

> This patch seems to be moving around quite a bit of code. Would it be possible to do some of the reorganization before this patch as a NFC to ease reviewing this?

So reorganization has been done as you've seen, for the rest is was quite hard. So I left some comments in this patch.



================
Comment at: libcxx/include/__format/formatter_integral.h:146
+template <integral _Tp>
+_LIBCPP_HIDE_FROM_ABI char* __to_buffer(char* __first, char* __last, _Tp __value, int __base) {
+  // TODO FMT Evaluate code overhead due to not calling the internal function
----------------
This hunk was at line 82.


================
Comment at: libcxx/include/__format/formatter_integral.h:264
+template <unsigned_integral _Tp, class _CharT>
+_LIBCPP_HIDE_FROM_ABI auto __format_integer(
+    _Tp __value, auto& __ctx, __format_spec::__parsed_specifications<_CharT> __specs, bool __negative = false)
----------------
Line 254 __format_unsigned_integral


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128139/new/

https://reviews.llvm.org/D128139