[libcxx-commits] [PATCH] D128400: [libc++][NFC] Replace enable_if with __enable_if_t in a few places
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Jun 23 09:27:07 PDT 2022
Mordante added a comment.
In general I'm happy. But please avoid unrelated NFC code changes is these kind of commits. Especially since the title nor the description mentions them. (Thus some minor whitespace fixes are not an issue.)
================
Comment at: libcxx/include/__split_buffer:121
template <class _InputIter>
- typename enable_if
- <
- __is_cpp17_input_iterator<_InputIter>::value &&
- !__is_cpp17_forward_iterator<_InputIter>::value,
- void
- >::type
+ __enable_if_t<__is_exactly_cpp17_input_iterator<_InputIter>::value>
__construct_at_end(_InputIter __first, _InputIter __last);
----------------
I'm not happy with this change in this commit, please make a separate review for it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128400/new/
https://reviews.llvm.org/D128400
More information about the libcxx-commits
mailing list