[libcxx-commits] [PATCH] D127226: [libc++] Simplify type_traits and use more builtins

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D127226#3602787 <https://reviews.llvm.org/D127226#3602787>, @manojgupta wrote:

> This seems like same as the problem that was fixed by https://reviews.llvm.org/rGe6a39f00e8d0cd3684df54fb03d288efe2969202 and re-introduced by this patch.

Unfortunately it seems this revert wasn't followed up by a regression test.

I agree we should fix this **and** add tests for `__float128` and for other non-standard types broken by this commit.
That way we can avoid future regressions.

I think we should also have a look at the gcc/clang manuals for additional non-standard types and evaluate their status.

@ayzhao, @manojgupta, @cjdb are you aware of other types that are broken by this commit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127226/new/

https://reviews.llvm.org/D127226