[libcxx-commits] [PATCH] D128021: [libc++] Don't call key_eq in unordered_map/set rehashing routine

Ivan via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 22 19:04:10 PDT 2022

itrofimow marked an inline comment as done.
itrofimow added a comment.

In D128021#3593922 <https://reviews.llvm.org/D128021#3593922>, @Mordante wrote:

> One request, when you address a review comment, can you check the "done" button this makes reviewing easier.
> I had a look at the changes and I'm wondering about the impact on the size of the binary. You add one template argument to "only" adjust the `__rehash` function. This means the `__hash_table` for `unordered_map<K, V>` and `unordered_multimap<K, V>` will be different after this change. Could you provide some numbers regarding how much the binary will grow when an applications uses both `unordered_map<K, V>` and unordered_multimap<K, V>`?

Would this example <https://pastebin.com/raw/64AgVneW> be enough?
I could've messed up compile flags, and guidance would be appreciated if i did so

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list