[libcxx-commits] [PATCH] D128215: [libc++] Reduces std::to_chars instantiations.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/type_traits:1025
+template <class _Tp>
+using __make_32_64_or_128_bit_t = typename conditional<
+    is_signed<_Tp>::value,
----------------
ldionne wrote:
> philnik wrote:
> > Mordante wrote:
> > > Note I'm not fond of this name, so I'm open to suggestions for a better name.
> > Maybe `__extend_to_32_64_or_128_bit_t`? It's also not exactly perfect, but I think it describes it a bit better.
> Just throwing another suggestion out there, but perhaps something like `__widen_up_to_128_t` would be reasonable?
Based on the suggestions I keep the original name, but thanks for them!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128215/new/

https://reviews.llvm.org/D128215