[libcxx-commits] [PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

Wed Jun 22 05:30:29 PDT 2022

GuillaumeGomez added a comment.

In D127460#3601193 <https://reviews.llvm.org/D127460#3601193>, @xbolva00 wrote:

> Patch description needs to be added, especially answer the question why we should rename it, why we want it..

I updated the description to explain why it is needed. I'm not sure how big it's supposed to be so I didn't enter into the details though.

In D127460#3601205 <https://reviews.llvm.org/D127460#3601205>, @xbolva00 wrote:

> In D127460#3601152 <https://reviews.llvm.org/D127460#3601152>, @GuillaumeGomez wrote:
>
>> This is my first LLVM contribution so I don't think I do? If I do have a commit access anyway, do you have a link to the documentation where it explains what I'm supposed to do by any chance?
>
> https://llvm.org/docs/DeveloperPolicy.html#id17

Thanks! Once this is approved, I'll do it then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460