[libcxx-commits] [PATCH] D127919: [libc++] Disentangle _If, _Or and _And

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 21 14:01:11 PDT 2022


EricWF accepted this revision.
EricWF added a comment.

Frankly, I'm not sure that keeping logical operators together is "disentangling" them. They're pretty tightly grouped.
And I  can't say understand the point or value of all this churn either.

But on a purely technical level, this change LGTM.



================
Comment at: libcxx/include/__type_traits/conjunction.h:53
+template <class... _Pred>
+using _And _LIBCPP_NODEBUG = decltype(__and_helper<_Pred...>(0));
+
----------------
ADL. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127919/new/

https://reviews.llvm.org/D127919



More information about the libcxx-commits mailing list