[libcxx-commits] [PATCH] D126738: [libc++][NFC] Inline the definition of ~basic_ios()

Alan Zhao via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 21 13:05:30 PDT 2022


ayzhao abandoned this revision.
ayzhao added a comment.

In D126738#3599952 <https://reviews.llvm.org/D126738#3599952>, @ldionne wrote:

> In D126738#3564733 <https://reviews.llvm.org/D126738#3564733>, @ayzhao wrote:
>
>> In D126738#3564693 <https://reviews.llvm.org/D126738#3564693>, @ldionne wrote:
>>
>>> I just landed D122941 <https://reviews.llvm.org/D122941> -- I think you should check whether this is still an issue for you.
>>
>> So far, your patch does seem to work, but I'll need to wait to see if our bots are green when we roll libc++. Thanks!
>
> Any news? If it works, let's abandon this patch to clear the review queue.

I'll abandon this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126738/new/

https://reviews.llvm.org/D126738



More information about the libcxx-commits mailing list