[libcxx-commits] [PATCH] D128053: [libc++] Pass -fno-modules to clang-tidy instead of disabling it for the modules build

[Nikolas Klauser via Phabricator via libcxx-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG43913357b47d: [libc++] Pass -fno-modules to clang-tidy instead of disabling it for the… (authored by philnik).

Changed prior to commit:
  https://reviews.llvm.org/D128053?vs=437875&id=438780#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128053/new/

https://reviews.llvm.org/D128053

Files:
  libcxx/test/libcxx/clang_tidy.sh.cpp


Index: libcxx/test/libcxx/clang_tidy.sh.cpp
===================================================================
--- libcxx/test/libcxx/clang_tidy.sh.cpp
+++ libcxx/test/libcxx/clang_tidy.sh.cpp
@@ -7,9 +7,9 @@
 //===----------------------------------------------------------------------===//
 
 // REQUIRES: has-clang-tidy
-// XFAIL: modules-build
 
-// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* -- -Wweak-vtables -Wno-unknown-warning-option %{compile_flags}
+// TODO: run clang-tidy with modules enabled once they are supported
+// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* -- -Wweak-vtables -Wno-unknown-warning-option %{compile_flags} -fno-modules
 // -Wno-unknown-warning-option tells clang-tidy to ignore '-W' command-line arguments that it doesn't know.
 // There are some GCC-specific ones where clang-tidy would warn otherwise.
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128053.438780.patch
Type: text/x-patch
Size: 874 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220621/c0bc4496/attachment-0001.bin>