[libcxx-commits] [libcxx] 4391335 - [libc++] Pass -fno-modules to clang-tidy instead of disabling it for the modules build

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 21 11:28:47 PDT 2022


Author: Nikolas Klauser
Date: 2022-06-21T20:28:27+02:00
New Revision: 43913357b47d01801466b5a27ff2955f1865ed43

URL: https://github.com/llvm/llvm-project/commit/43913357b47d01801466b5a27ff2955f1865ed43
DIFF: https://github.com/llvm/llvm-project/commit/43913357b47d01801466b5a27ff2955f1865ed43.diff

LOG: [libc++] Pass -fno-modules to clang-tidy instead of disabling it for the modules build

Reviewed By: ldionne, #libc

Spies: libcxx-commits

Differential Revision: https://reviews.llvm.org/D128053

Added: 
    

Modified: 
    libcxx/test/libcxx/clang_tidy.sh.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/libcxx/clang_tidy.sh.cpp b/libcxx/test/libcxx/clang_tidy.sh.cpp
index a62eeef0c680..bd83555cdc75 100644
--- a/libcxx/test/libcxx/clang_tidy.sh.cpp
+++ b/libcxx/test/libcxx/clang_tidy.sh.cpp
@@ -7,9 +7,9 @@
 //===----------------------------------------------------------------------===//
 
 // REQUIRES: has-clang-tidy
-// XFAIL: modules-build
 
-// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* -- -Wweak-vtables -Wno-unknown-warning-option %{compile_flags}
+// TODO: run clang-tidy with modules enabled once they are supported
+// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* -- -Wweak-vtables -Wno-unknown-warning-option %{compile_flags} -fno-modules
 // -Wno-unknown-warning-option tells clang-tidy to ignore '-W' command-line arguments that it doesn't know.
 // There are some GCC-specific ones where clang-tidy would warn otherwise.
 


        


More information about the libcxx-commits mailing list