[libcxx-commits] [PATCH] D128007: [libc++] Simplify the visibility attributes

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/include/__config:558
+#  if !defined(_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS)
+#    define _LIBCPP_VISIBILITY(vis) __attribute__((__visibility__(vis)))
+#  else
----------------
If we want to eventually refactor the Windows side of availability macros, I think we should have `_LIBCPP_VISIBILITY_HIDDEN` and `_LIBCPP_VISIBILITY_DEFAULT` instead of a macro parameter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128007/new/

https://reviews.llvm.org/D128007