[libcxx-commits] [PATCH] D127760: [libc++][NFC] Merges unused functions in callers.

[Joe Loser via Phabricator via libcxx-commits]

jloser added inline comments.


================
Comment at: libcxx/test/libcxx/numerics/bit.ops.pass.cpp:34
-    static_assert( std::__libcpp_popcount(v) == 7, "");
-    static_assert( std::__bit_log2(v) == 12, "");
-    static_assert(!std::__has_single_bit(v), "");
----------------
This is a drop in test coverage - I think we should keep this one for `__bit_log2`. In general, I think we should:
- Keep existing test coverage for the private functions kept (i.e. ones that had two or more call sites used by public functions).
- Verify existing coverage for public functions where we removed the private function it delegated to if we removed the private function (since it only had one call site). 

How does that sound? If you're up for it, we could go one step further and verify the `noexcept` properties.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127760/new/

https://reviews.llvm.org/D127760