[libcxx-commits] [PATCH] D128081: [libc++] Inline the string constructors

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

I don't think this change is something we should do.

First, this has a lot of functional changes. Like allowing the compiler to inline these functions, which we've explicitly externally instantiated and were consciously put out of line for that reason. This will result in a large code size increase.
And it's not something I think we should do to our users. It largely negates the ABI exports libc++ intentional created.

Second, IMHO, the boilerplate is fine. It's not boilerplate we can get wrong, since the compiler will enforce correctness. I don' think this boilerplate is significant enough to warrant the code size changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128081/new/

https://reviews.llvm.org/D128081