[libcxx-commits] [PATCH] D128214: [libc++] Makes `unique_ptr operator*() noexcept.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante planned changes to this revision.
Mordante added a comment.

Thanks for the review!

However I will put this on hold. The CI failure seems to indicate there's an issue with the LWG issue. GCC agrees with Clang so I need to do some more investigation.



================
Comment at: libcxx/include/__memory/unique_ptr.h:271
+  _LIBCPP_INLINE_VISIBILITY typename add_lvalue_reference<_Tp>::type
+  operator*() const _NOEXCEPT_(_NOEXCEPT_(*declval<pointer>())) {
     return *__ptr_.first();
----------------
philnik wrote:
> It gets removed if `noexcept()` isn't supported anyways.
Good point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128214/new/

https://reviews.llvm.org/D128214