[libcxx-commits] [PATCH] D127978: [libc++][test] Replaces TEST_IS_CONSTANT_EVALUATED.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 2 inline comments as done.
Mordante added inline comments.


================
Comment at: libcxx/test/std/strings/string.view/string.view.comparison/not_equal.pass.cpp:58
 
-            if (!TEST_IS_CONSTANT_EVALUATED || TEST_STD_VER >= 20) {
+			// fails in C++17
+            if (!is_constant_evaluated(TestedCppVersion::Cpp14) || TEST_STD_VER >= 20) {
----------------
jloser wrote:
> Mordante wrote:
> > I'll remove this comment before landing or the next upload whatever comes first.
> That's interesting. Why does it fail in C++17 mode? 
Initially I only used `TestedCppVersion::Cpp20` which caused the build to file. After correcting this I forgot to remove this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127978/new/

https://reviews.llvm.org/D127978