[libcxx-commits] [PATCH] D127908: [libc++] Remove std::function in C++03

[Joe Loser via Phabricator via libcxx-commits]

jloser added inline comments.


================
Comment at: libcxx/docs/ReleaseNotes.rst:145
 
+- ``std::function`` has been remove from C++03. If you are using it please remove the uses
+  or upgrade to C++11. It is possible to re-enable ``std::function`` by defining
----------------
philnik wrote:
> ldionne wrote:
> > jloser wrote:
> > > There are a few typos here. How about this, instead?
> > > 
> > > 
> > > 
> > > > `std::function` has been removed in C++03.  If you are using it, please remove usages or upgrade to C++11 or later. It is possible to re-enable `std::function` in C++03 mode by defining `_LIBCPP_ENABLE_CXX03_FUNCTION`. This option will be removed in LLVM 16.
> > > 
> > > 
> > I like this reformulation. In particular, let's make sure to use LLVM 16, not libc++16 (which is not an official thing).
> You say `a few typos`. Did I miss any, or was there just `removed` without the `d`?
I think there's one left. I'd reword "This option it" to "This option" (i.e. drop the word "it") to make this sentence read clearer IMO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127908/new/

https://reviews.llvm.org/D127908