[libcxx-commits] [PATCH] D126667: [libc++][CI] Updates GCC to version 12.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for the review!



================
Comment at: libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.char_array.pass.cpp:10
 // UNSUPPORTED: libcpp-has-no-incomplete-format
-// TODO FMT Evaluate gcc-11 status
-// UNSUPPORTED: gcc-11
+// TODO FMT __builtin_memcpy isn't constexpr in GCC
+// UNSUPPORTED: gcc-12
----------------
philnik wrote:
> Couldn't you just use `std::copy_n` for this?
I probably can; however when I wrote the test (in the GCC-10 era) there were a lot more issues.
(Actually that's not true, it was for the `formatter.const_char_array.pass.cpp` which this is a copy-paste of.)

But I want to look whether I can refactor this test, I learned a bit more about "string literals" as template argument.
However I prefer to do that in a separate commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126667/new/

https://reviews.llvm.org/D126667