[libcxx-commits] [PATCH] D125121: [runtimes] Generalize how we reorder projects

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: runtimes/CMakeLists.txt:25
+include(SortSubset)
+sort_subset("${LLVM_ALL_RUNTIMES}" "${LLVM_ENABLE_RUNTIMES}" LLVM_ENABLE_RUNTIMES)
 
----------------
This patch makes it impossible to build `llvm-libgcc` because `LLVM_ALL_RUNTIMES` deliberately doesn't include `llvm-libgcc`. I think this can be fixed by changing the first parameter to `"${LLVM_ALL_RUNTIMES};llvm-libgcc"`, or by adding a variable that genuinely has all the runtimes (in reality, that would be spelt `LLVM_ALL_RUNTIMES`, and the current `LLVM_ALL_RUNTIMES` becomes `LLVM_USER_ALL_RUNTIMES`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125121/new/

https://reviews.llvm.org/D125121