[libcxx-commits] [PATCH] D127587: [libc++] Use explicit module cache path in tests

Alex Brachet via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 16 21:17:08 PDT 2022

abrachet added a comment.

In D127587#3582811 <https://reviews.llvm.org/D127587#3582811>, @ldionne wrote:

> In D127587#3582808 <https://reviews.llvm.org/D127587#3582808>, @ldionne wrote:
>> @abrachet Please don't commit patches to libc++ without having approval from the libc++ review group.
> By the way, I'm not scolding, just making sure everybody follows the process :-). Let's have a discussion now that the immediate problem is solved!

No worries I'm not feeling scolded :) I will wait next time.

In D127587#3582808 <https://reviews.llvm.org/D127587#3582808>, @ldionne wrote:

> Thanks for wanting to improve the test suite -- this is indeed a slow test that creates a lot of stuff on the side. My main comment is actually whether it would make sense to reuse a modules-cache path in the whole test suite (even across tests)?

Sure I could look into that. I'm not too familiar with libcxx's testing infrastructure, do you reckon that would be added to all of the `%{compile_flags}` substitutions?

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list