[libcxx-commits] [PATCH] D127672: [libc++] Test the size of basic_string

[Hubert Tong via Phabricator via libcxx-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: libcxx/test/libcxx/strings/basic.string/alignof.compile.pass.cpp:99
+static_assert(alignof(test_string<char>) == 4, "");
+static_assert(alignof(small_string<char>) == 2, "");
+
----------------
hubert.reinterpretcast wrote:
> hubert.reinterpretcast wrote:
> > This used to pass on AIX, but changes to use bitfields (without applying `_LIBCPP_PACKED_BYTE_FOR_AIX`) has broken this.
> However, using the above also causes other members to be less aligned if padding is not explicitly added.
Or rather it causes the string type to be less aligned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127672/new/

https://reviews.llvm.org/D127672