[libcxx-commits] [PATCH] D127606: [libc++] Simplify __config a bit

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I'd like the commit message to explain what's going on here since it's not obvious. From our discussion:

> Simplify logic in `__config` by assuming that we are using Clang in C++03 mode. Also, use standardized feature-test macros instead of compiler-specific checks (like `__has_feature`) in a couple of places.

LGTM with:

- A more descriptive commit message
- CI passing
- The visibility changes split out.

Thanks a lot, this is actually a really nice refactoring. I am especially looking forward to the split-up patch refactoring visibility attributes.



================
Comment at: libcxx/include/__config:535
 
+#  ifndef _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS
+#    define _LIBCPP_VISIBILITY_DEFAULT __attribute__((__visibility__("default")))
----------------
Can you please split the visibility part of this change into another patch? It's really not related to the rest of the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127606/new/

https://reviews.llvm.org/D127606