[libcxx-commits] [PATCH] D127953: [libc++] Mark standard-mandated includes as such

Thu Jun 16 09:23:12 PDT 2022

jloser added a comment.

In D127953#3589266 <https://reviews.llvm.org/D127953#3589266>, @Mordante wrote:

> Thanks for working on this!
>
> In D127953#3588836 <https://reviews.llvm.org/D127953#3588836>, @jloser wrote:
>
>> This seems reasonable to me. Do you think it's worth adding a test for this behavior to avoid regression in the future, or do you think it's overkill?
>
> I would like that. Maybe we can make automatically generated tests for some parts, like we already do for the feature-test macros.

Yeah, that's along the lines of what I was thinking for the (proposed) generated test for this sort of thing. I'd be in favor of that direction as it yields long-term value IMO.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127953/new/

https://reviews.llvm.org/D127953