[libcxx-commits] [PATCH] D127587: [libc++] Use explicit module cache path in tests

[Louis Dionne via Phabricator via libcxx-commits]

ldionne reopened this revision.
ldionne added a comment.

@abrachet Please don't commit patches to libc++ without having approval from the libc++ review group.

Thanks for wanting to improve the test suite -- this is indeed a slow test that creates a lot of stuff on the side. My main comment is actually whether it would make sense to reuse a modules-cache path in the whole test suite (even across tests)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127587/new/

https://reviews.llvm.org/D127587