[libcxx-commits] [PATCH] D127669: [libc++] Robust against C++20-hostile iterators

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/test/std/algorithms/robust_against_cpp20_hostile_iterators.compile.pass.cpp:76
+
+void test() {
+  Cpp20HostileIterator<int*> it;
----------------
EricWF wrote:
> You might as well run these tests over some meaningful input. Then if our implementations do something else weird there's a chance the sanitizers can catch it.
This should be catched by the runtime tests. They already run with a bunch of different iterator types. This test is just to make sure that the classic STL algorithms can still be instantiated with not-so-nice iterators.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127669/new/

https://reviews.llvm.org/D127669