[libcxx-commits] [PATCH] D124789: [libc++] Find a clang-format everybody is happy with

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 13 14:54:52 PDT 2022

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This is not perfect, but it looks reasonable to me. However, some comments;

1. Let's keep it soft-fail for a bit until we've gained some hands-on experience with formatting our code. We can have a not-yet-enforced expectations that contributors run clang-format, and start enforcing it in 1-2 weeks once everybody has had a bit of experience with it.
2. Let's not make changes to actual files in this patch.

So, basically, let's land the changes to `.clang-format`, give ourselves 2 weeks to get accustomed, and then make it hard-fail in the CI. For the next 2 weeks, there will be a not-CI-enforced-yet expectation that people clang-format their changes. That will let us adjust if needed.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list