[libcxx-commits] [PATCH] D127644: [libc++][NFC] clang-format <__config>

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 13 14:52:31 PDT 2022

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D127644#3578970 <https://reviews.llvm.org/D127644#3578970>, @EricWF wrote:

> I really don't know if this is worth the cost of losing all the blame history.
> I know you can get around whitespace changes, but still.
> I think we should just incrementally format this as it gets changed.

I actually just tried pulling this patch and adding the commit to `.git-blame-ignore-revs`, and it's basically as-if this commit had never been done, so it's not too disruptive. I think `__config` is somewhat special in that these changes are almost exclusively whitespace-only changes, which `git blame` can deal with really well. This wouldn't be the case for refactoring most other headers.

Given that the alternative is to get a bunch of formatting changes mixed into day-to-day reviews, I think I'd rather do this file all at once and add the commit to `git-blame-ignore-revs`.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list