[libcxx-commits] [PATCH] D127444: [libc++] Use ABI tags instead of internal linkage to provide per-TU insulation

Mon Jun 13 14:38:27 PDT 2022

philnik added a comment.

In D127444#3579773 <https://reviews.llvm.org/D127444#3579773>, @EricWF wrote:

> In D127444#3579756 <https://reviews.llvm.org/D127444#3579756>, @philnik wrote:
>
>> Just out of interest: Does this remove the problem that we `always_inline` a lot of functions with GCC?
>
> At this point I hope we're only `always_inlining` functions for performance/code size reasons, rather than
> as ABI management. Though it may still be needed to battle with extern template semantics.
>
> Specifically which `always inline` usages are you talking about?

I mean that GCC doesn't provide `internal_linkage` (https://godbolt.org/z/8jTzq8zvz), which means that we fall back to `always_inline` with GCC with `_LIBCPP_HIDE_FROM_ABI_PER_TU` enabled.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127444/new/

https://reviews.llvm.org/D127444