[libcxx-commits] [PATCH] D127606: [libc++] Simplify __config a bit

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 13 11:54:11 PDT 2022

Mordante added a comment.

SGTM, but I will need some time to have a good look at the changes made.

Comment at: libcxx/include/__config:209
+#if !defined(_LIBCPP_COMPILER_CLANG_BASED) && __cplusplus < 201103L
+#  error "libc++ does not support compilers other than Clang in C++03. Please enable C++11."
philnik wrote:
> Mordante wrote:
> > One of the things bothering about this file is the lack-of overview what indention level parts have.
> > After processing this patch would it make sense to format this file?
> > Then all `# foo` parts have the proper indention.
> I'm not sure. clang-format indents everything an unneeded level because we have `#ifdef __cplusplus` around the whole file. What I've formatted here was done mostly by hand. Although I think it still would be a major improvement over the status quo. I don't think anybody (other than Arthur maybe) would actually care if the default indentation is one to far in. So yeah, it's probably a good idea.
Mainly to make it easier to spot how deeply nested some parts are. Especially in the compiler specific parts.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list