[libcxx-commits] [PATCH] D127358: [libc++] Use a different namespace for the debug-mode version of the library

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/CMakeLists.txt:191
+if (LIBCXX_ENABLE_DEBUG_MODE)
+  set(_default_abi_namespace "${_default_abi_namespace}d")
+endif()
----------------
philnik wrote:
> I think versioning the debug namespace in the same way we version the non-debug namespace isn't a good idea. It gives the impression that the ABI for the debug mode is stable. I would suggest just using `__libcxx_debug_ns` as the namespace or use the libc++ version in the mangling to catch these kinds of mismatches as well. Maybe `__libcxx_debug_<version>`?
But I assume we can still use ABI v1 and ABI v2 with debug mode. In which case this needs to remain.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127358/new/

https://reviews.llvm.org/D127358