[libcxx-commits] [PATCH] D127470: [libcxx][AIX] Switch build compiler to clang

David Tenty via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 13 10:04:40 PDT 2022


daltenty accepted this revision.
daltenty added a comment.

LGTM, with minor nit



================
Comment at: libcxx/include/__config:131
 // of inline functions to be emitted anyway. Our own non-inline copy would
 // conflict with the dllexport-emitted copy, so we disable it.
 #    define _LIBCPP_DEPRECATED_ABI_LEGACY_LIBRARY_DEFINITIONS_FOR_INLINE_FUNCTIONS
----------------
nit: It's probably worth a comment to explain this:



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127470/new/

https://reviews.llvm.org/D127470



More information about the libcxx-commits mailing list