[libcxx-commits] [PATCH] D127470: [libcxx][AIX] Switch build compiler to clang

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with comments addressed.



================
Comment at: libcxx/CMakeLists.txt:472
+if (${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+  set(CMAKE_AR "/usr/bin/ar")
+endif()
----------------
daltenty wrote:
> Would setting this in our AIX CMake cache file be sufficient? That might be preferable to hardcoding part of the tool chain in each of the top-level CMake files.
Yes, please do it in the CMake cache instead to avoid adding platform-specific code to the `CMakeLists.txt`.


================
Comment at: libcxxabi/CMakeLists.txt:232
 
+if (${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+  set(CMAKE_AR "/usr/bin/ar")
----------------
Same comment here.


================
Comment at: libunwind/CMakeLists.txt:146
+if (${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+  set(CMAKE_AR "/usr/bin/ar")
+endif()
----------------
And here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127470/new/

https://reviews.llvm.org/D127470