[libcxx-commits] [PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

Mon Jun 13 07:49:19 PDT 2022

ldionne accepted this revision as: libc++abi.
ldionne added a comment.

LGTM for libc++abi once my comment is addressed, which should make the libc++ CI pass. Please don't submit this until you have a green check-mark from the libc++ CI.

================
Comment at: llvm/include/llvm/ADT/Triple.h:1031
   /// @}
   /// @name Static helpers for IDs.
   /// @{
----------------
Comment applies to `test_demangle.pass.cpp` (it's a binary file so I can't comment on it). The test is currently failing because you need to change `_ZN4llvm9Intrinsic25getIntrinsicForClangBuiltinEPKcS2_` to `_ZN4llvm9Intrinsic27getIntrinsicForClangBuiltinEPKcS2_`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460