[libcxx-commits] [PATCH] D127631: [libc++] Granularize some more of <type_traits>

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 13 07:45:46 PDT 2022

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I'm fine with this, but I'd like to record that the benefit of splitting small quasi-one-liners into a separate file is limited. I think it's fine for consistency, but if we end up using intrinsics for almost all of the type traits, it may make sense to group them into slightly larger headers, because the boilerplate of a header for 4-5 lines of content is not really worth it.

But like I said, this is consistent with the rest of the code so let's go ahead.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list