[libcxx-commits] [PATCH] D127577: [libc++] Fix std::lower_bound with C++20-hostile iterators

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added inline comments.


================
Comment at: libcxx/include/__algorithm/generic_algorithm_helper.h:21
+namespace _Namespace {
+enum _Namespace : bool {
+  _Ranges,
----------------
EricWF wrote:
> Or `struct _Namespace { enum : bool { _Std, _Ranges }; };`. Having the symbol have two entirely different meanings has a mean code smell.
That said, I don't really care to see this addressed at the moment. So just ignore me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127577/new/

https://reviews.llvm.org/D127577