[libcxx-commits] [PATCH] D127577: [libc++] Fix std::lower_bound with C++20-hostile iterators

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Jun 12 08:57:48 PDT 2022


EricWF added inline comments.


================
Comment at: libcxx/test/support/test_iterators.h:831
+
+  friend Sub operator+(Sub it, difference_type d);
+  friend Sub operator+(difference_type d, Sub it);
----------------
You'll probably need to stub out these functions so we can write a actual runtime test, since the compile time tests can't catch the breakage we're fixing here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127577/new/

https://reviews.llvm.org/D127577



More information about the libcxx-commits mailing list