[libcxx-commits] [PATCH] D127570: [libc++][format] Use forwarding references.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Herald added a project: All.
Mordante updated this revision to Diff 436158.
Mordante added a comment.
Mordante updated this revision to Diff 436197.
Mordante edited the summary of this revision.
Mordante published this revision for review.
Mordante added reviewers: ldionne, vitaut.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Add a separate test for move only types.


Mordante added a comment.

Fixes CI and minor cleanups.


This implements a not accepted LWG issue. Not doing so would require
integral types to use the handle class instead of being directly stored
in the basic_format_arg.

The previous code used `std::forward` in places where it wasn't required
by the Standard. These are now removed.

Implements:

- P2418R2 Add support for std::generator-like types to std::format
- LWG 3631 basic_format_arg(T&&) should use remove_cvref_t<T> throughout


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127570

Files:
  libcxx/docs/ReleaseNotes.rst
  libcxx/docs/Status/Cxx20Papers.csv
  libcxx/docs/Status/Cxx2bIssues.csv
  libcxx/include/__format/format_arg.h
  libcxx/include/__format/format_arg_store.h
  libcxx/include/format
  libcxx/test/std/utilities/format/format.arguments/format.arg.store/make_format_args.pass.cpp
  libcxx/test/std/utilities/format/format.arguments/format.arg.store/make_wformat_args.pass.cpp
  libcxx/test/std/utilities/format/format.functions/P2418.pass.cpp
  libcxx/test/std/utilities/format/format.functions/format.verify.cpp
  libcxx/test/std/utilities/format/format.functions/format_tests.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127570.436197.patch
Type: text/x-patch
Size: 27804 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220612/0d755f4b/attachment-0001.bin>