[libcxx-commits] [PATCH] D127590: [libc++] Removes a GCC bug work-around.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Jun 12 03:34:09 PDT 2022


Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/include/__tree:36-39
 template <class, class, class, class> class _LIBCPP_TEMPLATE_VIS map;
 template <class, class, class, class> class _LIBCPP_TEMPLATE_VIS multimap;
 template <class, class, class> class _LIBCPP_TEMPLATE_VIS set;
 template <class, class, class> class _LIBCPP_TEMPLATE_VIS multiset;
----------------
philnik wrote:
> This looks really weird.
Since they are used as friends, see my comment below.


================
Comment at: libcxx/include/__tree:889
     template <class, class, class> friend class _LIBCPP_TEMPLATE_VIS set;
     template <class, class, class> friend class _LIBCPP_TEMPLATE_VIS multiset;
 };
----------------
They are used as friends here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127590/new/

https://reviews.llvm.org/D127590



More information about the libcxx-commits mailing list