[libcxx-commits] [PATCH] D125496: [libc++] Simplify the string structures a bit more

Sat Jun 11 11:27:33 PDT 2022

philnik marked an inline comment as done.
philnik added a comment.

In D125496#3575712 <https://reviews.llvm.org/D125496#3575712>, @hubert.reinterpretcast wrote:

> In D125496#3575088 <https://reviews.llvm.org/D125496#3575088>, @ayzhao wrote:
>
>> Chrome is observing failures on Windows caused by this patch: https://crbug.com/1334441
>
> I will note this patch fixes an ABI break on AIX caused by https://reviews.llvm.org/D123580.

Do you want to tell me that using `size_type` is correct for AIX and `unsigned char` is correct for Windows?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125496/new/

https://reviews.llvm.org/D125496